I notice we don't have any caching here, should we maybe add that?

I notice we don't have any caching here, should we maybe add that?

Don't see big sense. All checks are fast, rarely changes.

Needs MSRV bump.

did you change the settings here also @burrbull ? The settings right now are setup for merge_group, but that has not been implemented yet

did you change the settings here also @burrbull ? The settings right now are setup for merge_group, but that has not been implemented yet

Add to this PR, please.

I also cannot add clippy restriction.

I'll add it

clippy is behind build now

this is not a good way to do it, since if we update msrv we'd have to bump here also, we can fix it with a name or switching to a job with needs. Since this is only a few checks I'll name the job

clippy is behind build now

I don't like this. check and clippy should be different jobs.

clippy is check though, they do exactly the same thing, just more knobs with clippy.

clippy is check though, they do exactly the same thing, just more knobs with clippy.

if job fails I want to see is it build fail or just clippy.
Build must be stable. Clippy often adds new check. Possibly we even should not add clippy to merge restrictions.

we don't use -D warnings so there shouldn't be any issues with warnings from clippy

oh, we do do #[deny(warnings)], that's bad :3

I'll separate them

actually, I'd rather fix the deny first and then we can determine if we should split it, I'll let you decide how it should be afterwards